Redundant CS transition #5192
Merged
Redundant CS transition #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the Concurrent Scavenger transition at the begining of Scavenger's percolate, since we will attempt it anyway before really percolating as part of MM_ParallelGlobalGC::completeExternalConcurrentCycle(). Having both attempts can cause problems if first one aborts and then instead of directly percolating, the second one may trigger another STW increment seeing the previous one did not complete cycle (not knowing it aborted). For a few trace points adjusted priorities, based on how important they are vs how frequently they occur. Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
|
@genie-omr build all |
dmitripivkine
approved these changes
May 13, 2020
youngar
approved these changes
May 13, 2020
|
The CI failures are due to infrastructural issues, UNB machines are having trouble cloning OMR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Concurrent Scavenger transition at the begining of
Scavenger's percolate, since we will attempt it anyway before really
percolating as part of
MM_ParallelGlobalGC::completeExternalConcurrentCycle().
Having both attempts can cause problems if first one aborts and then
instead of directly percolating, the second one may trigger another STW
increment seeing the previous one did not complete cycle (not knowing it
aborted).
For a few trace points adjusted priorities, based on how important they
are vs how frequently they occur.
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com