Fix incorrect spelling of J9_PROJECT_SPECIFIC #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that previously, there was code in the Power codegen guarded by the definition of a J9_ProjectSpecific macro. This was a misspelling of the J9_PROJECT_SPECIFIC macro, so this code was never actually used. This could cause incorrect behaviour in OpenJ9 if an irsload node appeared under an s2i node. The spelling of this check has been corrected so that the code should now be enabled correctly. Fixed: eclipse-omr#5137 Signed-off-by: Ben Thomas <ben@benthomas.ca>
|
@genie-omr build plinux,aix |
fjeremic
approved these changes
Apr 30, 2020
|
Not waiting for Travis since this is a Power only change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that previously, there was code in the Power codegen guarded by
the definition of a J9_ProjectSpecific macro. This was a misspelling of
the J9_PROJECT_SPECIFIC macro, so this code was never actually used.
This could cause incorrect behaviour in OpenJ9 if an irsload node
appeared under an s2i node. The spelling of this check has been
corrected so that the code should now be enabled correctly.
Fixed: #5137
Signed-off-by: Ben Thomas ben@benthomas.ca