Added constants for Unix Implementations in OMRSOCK API #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohaley
requested review from
charliegracie,
mstoodle,
rwy7 and
youngar
as code owners
caohaley
force-pushed
the
definitions
branch
2 times, most recently
from
daa2f8e
to
f89203a
Compare
Added new definitions in omrportsock.h to be used by users - The users will use the constants defined here for function calls in omrsock_addrinfo_create_hints and omrsock_socket, and so on. - More defined constants will be added here in the future. Issue: eclipse-omr#4795 Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Robert Young <rwy0717@gmail.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
8 tasks
|
@babsingh Ready for review. |
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
rwy7
reviewed
Mar 11, 2020
added 5 commits
March 12, 2020 21:05
Added os dependent constants for mapping OMRSOCK constants - These constants will be mapped to the OMRSOCK constants, which the users will use. - These constants are not used by the users and will be hidden from the users. - There will be internal mapping functions inside omrsock.c to map the two constants so that these constants are hidden from users. Issue: eclipse-omr#4795 Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Robert Young <rwy0717@gmail.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
Added constants mapping for implementing omrsock_socket - These constants are mapping OMR user interface constants to OS dependent constants, which will be needed by the system socket function to create a socket. - These are added for isolating the users from the system constants. - Functions needing to convert OMR to OS constants includes omrsock_getaddrinfo_create_hints and omrsock_socket Issue: eclipse-omr#4795 Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Robert Young <rwy0717@gmail.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
Added constants mapping for implementing omrsock_socket - These are for mapping OS dependent constants to OMR user interface. - Thse are added to isolate users from system constants. - Functing neeting this converting includes omrsock_getaddrinfo_family, omrsock_getaddrinfo_socktype, omrsock_getaddrinfo_protocol. Issue: eclipse-omr#4795 Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Robert Young <rwy0717@gmail.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
Fixed unix/omrsock.c to accept constants defined - Changed omrsock_getaddrinfo_create_hints so that it now accepts OMR defined constants and changes it to OS dependent constants. - Changed omrsock_getaddrinfo_family, sockType, and protocol to map to and return OMR defined constants. Issue: eclipse-omr#4795 Co-authored-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Robert Young <rwy0717@gmail.com> Signed-off-by: Haley Cao <haleycao88@hotmail.com>
Change the family, socktype, protocols to defined constants - Changed both test cases to accept and test new constants in test cases. Issue: eclipse-omr#4795 Signed-off-by: Haley Cao <haleycao88@hotmail.com>
|
@rwy0717 Ready for another round of review. |
rwy7
approved these changes
Mar 13, 2020
|
@genie-omr build all |
8 tasks
8 tasks
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR: #4832
Issue: #4795