CopyScanCache pool size #4859
Merged
CopyScanCache pool size #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce max and increment size of the pool by factor of 3.4x This is effectively fixing a regression where this pool increased due to decrease of minimum copy cache size from 32K to 8K about a couple of years ago. The heuristic for the size of the pool is now based on both min and max size of copy cache. Relying on just min size was too conservative. If GC dynamically decided to use small copy caches it means that parallelism is low, what in turn means that scan queue is mostly empty, hence the need for the caches is low. Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
dmitripivkine
approved these changes
Feb 24, 2020
|
The commit when we reduced min copy cache size (hence increased the size of the pool of copy caches): 198efe0#diff-be9812f14d8aa163e623256c7db995aa |
|
@youngar or @rwy0717 please proceed with further review |
|
@genie-omr build all |
|
infrastructure error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce max and increment size of the pool by factor of 3.4x
This is effectively fixing a regression where this pool increased due to
decrease of minimum copy cache size from 32K to 8K about a couple of
years ago.
The heuristic for the size of the pool is now based on both min and max
size of copy cache. Relying on just min size was too conservative. If GC
dynamically decided to use small copy caches it means that parallelism
is low, what in turn means that scan queue is mostly empty, hence the
need for the caches is low.
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com