Change control access of isLargePage in MemoryManager to public #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragaigor
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
@genie-omr build all |
rwy7
approved these changes
Jan 9, 2020
youngar
approved these changes
Jan 9, 2020
|
@bragaigor Can you update the copyright? |
|
@bragaigor It looks like you rolled in an extra commit, was this an accident? |
bragaigor
force-pushed
the
islargepages
branch
4 times, most recently
from
7472f2f
to
25f1a7f
Compare
|
@genie-omr build all |
amicic
reviewed
Jan 10, 2020
gc/base/GCExtensionsBase.hpp
Outdated
| @@ -257,6 +257,7 @@ class MM_GCExtensionsBase : public MM_BaseVirtual { | |||
| bool largePageWarnOnError; | |||
| bool largePageFailOnError; | |||
| bool largePageFailedToSatisfy; | |||
| bool isDoubleMapRequested; /** Value of -XXgc:enableDoubleMapping <true> or -XXgc:disableDoubleMapping <false> specified by the user */ | |||
There was a problem hiding this comment.
should not really refer to option name directly (they are specific for OpenJ9). let alone (in theory) they can be even set by some other means like shell environmental variables, property files etc.
bragaigor
changed the title
This update is required by eclipse-openj9/openj9#8254 Signed-off-by: Igor Braga <higorb1@gmail.com>
bragaigor
force-pushed
the
islargepages
branch
from
25f1a7f
to
54e7090
Compare
|
@genie-omr build all |
amicic
approved these changes
Jan 10, 2020
bragaigor
changed the title
bragaigor
added a commit
to bragaigor/omr
that referenced
this pull request
Jan 10, 2020
Change control access of isLargePage in MemoryManager to public eclipse-omr#4701 Add arraylet double map request field eclipse-omr#4704 Introduce double mapping verbose GC option for balanced GC policy where it outputs "true" if arraylet double mapping is enabled and "false" otherwise eclipse-omr#4705 Signed-off-by: Igor Braga <higorb1@gmail.com>
bragaigor
added a commit
to bragaigor/openj9
that referenced
this pull request
Jan 14, 2020
In systems that support huge pages, the heap is created using the available huge pages (normally 2MB). The path taken to create a heap with huge pages is different from the one taken when normal page sizes are used. In order for double map to work, heap must be created using mmap with a file descriptor associated with the heap. However, doing that with huge pages is not supported in early glibc versions; in such versions, glibc only supports mmap + MAP_HUGETLB with anonymous mapping, which is the opposite of what we want (with anonymous mapping we cannot use a file descriptor). For now we disable double mapping whenever huge pages are used; however in a later release we optimally want to enable it by using memfd_create(2) which also returns a file descriptor just like shm_open(3) but it uses the same semantics as other anonymous memory allocations unlike shm_open(3). Introduce double mapping verbose GC option for balanced GC policy This PR is dependent of eclipse-omr/omr#4701 Signed-off-by: Igor Braga <higorb1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change control access of isLargePage in MemoryManager to public
This update is required by eclipse-openj9/openj9#8254
Related to issue: #4703
Signed-off-by: Igor Braga higorb1@gmail.com