Fix incorrect binary encoding for tabortwc #4672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the prototypes for the tabortwc extended mnemonics were incorrect and were instead generating tabortdc instructions. This could cause undefined behaviour, since the upper word of a register containing a 32-bit value is generally considered undefined. This has now been fixed and these instructions should generate the correct binary encodings. Signed-off-by: Ben Thomas <ben@benthomas.ca>
|
Checked tabortwci (the ones we have are variations of it) in the ISA and indeed it should end with 69D. LGTM. |
|
@genie-omr build plinux,aix |
0xdaryl
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the prototypes for the tabortwc extended mnemonics were
incorrect and were instead generating tabortdc instructions. This could
cause undefined behaviour, since the upper word of a register containing
a 32-bit value is generally considered undefined. This has now been
fixed and these instructions should generate the correct binary
encodings.
Signed-off-by: Ben Thomas ben@benthomas.ca