Migrate Processor Detection from OpenJ9 to OMR part 1 #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanHa
requested review from
charliegracie,
mstoodle,
rwy7 and
youngar
as code owners
AidanHa
force-pushed
the
Issue4339
branch
3 times, most recently
from
738c6a2
to
d39f2b4
Compare
AidanHa
changed the title
AidanHa
changed the title
|
@genie-omr build all |
Move required macros, enums and structs from OpenJ9 to OMR's port library Add function signatures for processor/feature detection to OMR Implement processor detection on Windows Add processor and feature detection for Unix Includes Linux, AIX PPC and ZOS systems Add test to verify processor/feature detection. Signed-off-by: Aidan Ha <qbha@edu.uwaterloo.ca>
|
@genie-omr build all |
|
@genie-omr build arm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #4503
There was a CI compile error on X (https://ci.eclipse.org/openj9/job/Build_JDK11_x86-64_linux_cm_OMR/413/). From discussion with @rwy0717, we have decided to rename some macros/functions, as well as making
omrsysinfo_get_x86_cpuida static function. This fixes the build issues we were having on x that previous testing did not catch, while keeping our naming scheme consistent.Here is what the PR consist of:
-The original commit from #4503
-1 commit where I renamed all of the added static functions in
port/unix/omrport.cand-1 commit where I renamed the features' macro name to match the processors' macro names
-1 commit where I made
omrsysinfo_get_x86_cpuidstatic as per request here: #4656 (comment)