Export omrthread_attr_set_detachstate #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashu-mehra
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
@genie-omr build all Have you tested this change against J9? |
|
Can you update the copyright date in |
For some reason omrthread_attr_set_detachstate was not exported, while other similar functions are. omrthread_attr_set_detachstate is now needed by OpenJ9 project as part of this PR: eclipse-openj9/openj9#7940. Signed-off-by: Ashutosh Mehra <mehra.ashutosh@ibm.com>
ashu-mehra
force-pushed
the
export_detachstate
branch
from
3f1f708
to
ea23cbc
Compare
Yes, I tested these changes with OpenJ9 PR eclipse-openj9/openj9#7940 on Linux x86 and power.
Done |
|
It passed previous CI and OpenJ9 integration, so there is no need to launch another build for a copyright update. Thanks @ashu-mehra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason omrthread_attr_set_detachstate was not exported,
while other similar functions are.
omrthread_attr_set_detachstate is now needed by OpenJ9 project as part
of this PR: eclipse-openj9/openj9#7940.
Signed-off-by: Ashutosh Mehra mehra.ashutosh@ibm.com