AArch64: Implement tableEvaluator #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements tableEvaluator() for AArch64. Co-authored-by: KONNO Kazuhiro konno@jp.ibm.com Co-authored-by: Aaron Graham aaron.graham@unb.ca Co-authored-by: Md. Mahbubur Rahman mrahma15@unb.ca Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
This PR is based on the code from #4214. It generates the following instruction sequence for the |
0xdaryl
reviewed
Dec 4, 2019
| } | ||
| else | ||
| { | ||
| if (!constantIsUnsignedImm12(numBranchTableEntries)) |
There was a problem hiding this comment.
I think this if condition is being overly defensive. You already know from the if guarding entry to this code that the numBranchTableEntries is <= 5. I'd say just do the generateCompareImmInstruction.
There was a problem hiding this comment.
numBranchTableEntries is >=5 here. So it is possible that exceeds the range of unsigned imm12.
There was a problem hiding this comment.
Ugh. I read the condition above incorrectly.
|
@genie-omr build aarch64 |
0xdaryl
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements tableEvaluator() for AArch64.
Co-authored-by: KONNO Kazuhiro konno@jp.ibm.com
Co-authored-by: Aaron Graham aaron.graham@unb.ca
Co-authored-by: Md. Mahbubur Rahman mrahma15@unb.ca
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com