AArch64: Allow negative immediate offset for memory access #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really like this workaround, but I need to do something to allow the negative offset (-4) for accessing
I would appreciate alternative ideas. |
0xdaryl
reviewed
Dec 5, 2019
| } | ||
| else | ||
| { | ||
| TR_ASSERT(false, "Offset is too large for specified instruction."); |
There was a problem hiding this comment.
Let's make this a fatal assert.
There was a problem hiding this comment.
Changed to TR_ASSERT_FATAL().
| } | ||
| else | ||
| { | ||
| TR_ASSERT(false, "Offset is too large for specified instruction."); |
There was a problem hiding this comment.
Let's make this a fatal assert.
There was a problem hiding this comment.
Changed to TR_ASSERT_FATAL().
This commit rewrites the instruction "ldrimmw" (12-bit unsigned offset) to "ldurw" (9-bit signed offset) when a negative value is used as the offset. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
knn-k
force-pushed
the
aarch64memref14
branch
from
d436fa9
to
02c7167
Compare
|
@genie-omr build aarch64 |
0xdaryl
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rewrites the instruction "ldrimmw" (12-bit unsigned offset)
to "ldurw" (9-bit signed offset) when a negative value is used as the
offset.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com