Share implementation to re-reserve trampolines on code cache switch #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
commented
Nov 19, 2019
fjeremic
approved these changes
Nov 19, 2019
Each code generator duplicates logic to re-reserve a trampoline for a call target if the code cache is switched between the time the trampoline is first reserved (likely instruction selection) and binary encoding. The logic is nearly the same in all cases. Provide a common version that is shared by all code generators. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
|
@genie-omr build all |
|
Un-WIPing this as CI testing is back online. |
0xdaryl
changed the title
|
@genie-omr build zlinux,plinux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each code generator duplicates logic to re-reserve a trampoline for a
call target if the code cache is switched between the time the trampoline
is first reserved (likely instruction selection) and binary encoding.
The logic is nearly the same in all cases. Provide a common version
that is shared by all code generators.
Signed-off-by: Daryl Maier maier@ca.ibm.com