Add omrstr_convert target code page CP_ACP/CP_THREAD_ACP #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
@rwy0717 could you arrange a review? |
|
@genie-omr build all |
rwy7
reviewed
Oct 31, 2019
Added target encoding J9STR_CODE_WINDEFAULTACP/J9STR_CODE_WINTHREADACP for Windows code page CP_ACP/CP_THREAD_ACP. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
localepath
branch
from
7f7c97c
to
1fc5b76
Compare
|
@genie-omr build all |
rwy7
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add omrstr_convert target code page CP_ACP/CP_THREAD_ACP
Added target encoding
J9STR_CODE_WINDEFAULTACP/J9STR_CODE_WINTHREADACPfor Windows code pageCP_ACP/CP_THREAD_ACP.required by: eclipse-openj9/openj9#7607
Verified that this PR along with eclipse-openj9/openj9#7607 fix eclipse-openj9/openj9#6722.
FYI: @DanHeidinga @pshipton
Signed-off-by: Jason Feng fengj@ca.ibm.com