Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to OpenJ9 private linkage #4486

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Oct 19, 2019

J9 private linkage has been largely isolated to OpenJ9 and moved
into the J9 namespace. Remove unused references in OMR and for
code guarded in project-specific macros reference the appropriate
private linkage class in the J9 namespace.

Signed-off-by: Daryl Maier maier@ca.ibm.com

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Oct 19, 2019

@genie-omr build all

J9 private linkage has been largely isolated to OpenJ9 and moved
into the J9 namespace.  Remove unused references in OMR and for
code guarded in project-specific macros reference the appropriate
private linkage class in the J9 namespace.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 5, 2019

@genie-omr build all

@0xdaryl 0xdaryl changed the title WIP: Remove references to OpenJ9 private linkage Remove references to OpenJ9 private linkage Nov 5, 2019
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 5, 2019

Un-WIPing as all my private testing has passed. Ready for review/merge.

@fjeremic fjeremic self-assigned this Nov 5, 2019
@fjeremic fjeremic merged commit 4223066 into eclipse-omr:master Nov 5, 2019
@fjeremic
Copy link
Contributor

fjeremic commented Nov 5, 2019

For the record the AIX failure is related to the port library and was discussed in Slack. It is not related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants