-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AArch64: Add extraRegister to OMRMemoryReference #4225
Conversation
This is a revisit of #3953. |
Cancelling this PR. |
Reopened this PR. I have to add the
|
96d3de9
to
0498155
Compare
Rebased the code. |
0498155
to
c6320d5
Compare
Renamed |
@@ -63,6 +63,7 @@ class OMR_EXTENSIBLE MemoryReference : public OMR::MemoryReference | |||
|
|||
TR::UnresolvedDataSnippet *_unresolvedSnippet; | |||
TR::SymbolReference *_symbolReference; | |||
TR::Register *_extraRegister; // for use with unresolved snippet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to document what the extra register is for. Any downstream project can use it to associate an additional assigned register to a memory reference that can be used for project-specific purposes. This register is in addition to the base and index registers and isn't directly part of the addressing expression in the memory reference. An example of what this could be used for is to help synthesize unresolved data reference addresses at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments in the code on the potential use of the extra register.
@genie-omr build aarch64 |
This commit adds extraRegister and related code to OMRMemoryReference for AArch64. It will be used by UnresolvedSnippet. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
c6320d5
to
3377516
Compare
This commit adds extraRegister and related code to
OMRMemoryReference for AArch64.
It will be used by UnresolvedSnippet.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com