Remove OMR::Compilation::needRelocationsForStatics #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged after eclipse-openj9/openj9#6718 |
Leonardo2718
changed the title
|
I've added WIP as a prefix to the PR title to signal that this shouldn't be merged yet. Please remove the WIP once this PR can be safely merged. (i.e. after eclipse-openj9/openj9#6718 is merged). |
Replace the usage of that query with `CodeGenerator::needRelocationsForStatics`. They are supposed to be used in the same circumstances but it is more appropriate to have this query in the codegen, since different platforms may require different answers. Signed-off-by: Dmitry Ten <Dmitry.Ten@ibm.com>
dmitry-ten
force-pushed
the
relo-remove
branch
from
c3601e5
to
a59a951
Compare
dmitry-ten
changed the title
dmitry-ten
changed the title
|
Due to most recent discussion in eclipse-openj9/openj9#6718 it was decided to keep the codegen query and remove the compilation object one. Changed the commit, title and description of this PR to accommodate that. |
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the usage of that query with
CodeGenerator::needRelocationsForStatics.They are supposed to be used in the same circumstances but it is more appropriate to have this query in the codegen, since different platforms may require different answers.