AArch64: Implement aladdEvaluator() #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knn-k
force-pushed
the
aarch64eval44
branch
2 times, most recently
from
1cb7de3
to
fad8eca
Compare
knn-k
changed the title
|
Ready for review. |
0xdaryl
reviewed
Jul 20, 2019
| trgReg->setPinningArrayPointer(firstChild->getRegister()->getPinningArrayPointer()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this will accomplish the same thing for the code under the isInternalPointer() guard but with fewer calls and indirections. Correct me if I'm wrong though. This wouldn't work, for example, if the pinning array pointer symbol could ever be NULL, but I don't think that's possible.
if (node->isInternalPointer())
{
TR::AutomaticSymbol *pinningArrayPointerSymbol = NULL;
if (node->getPinningArrayPointer())
{
pinningArrayPointerSymbol = node->getPinningArrayPointer();
}
else
{
TR::Node *firstChild = node->getFirstChild();
if ((firstChild->getOpCodeValue() == TR::aload) &&
firstChild->getSymbolReference()->getSymbol()->isAuto() &&
firstChild->getSymbolReference()->getSymbol()->isPinningArrayPointer())
{
TR::Symbol *firstChildSymbol = firstChild->getSymbolReference()->getSymbol();
pinningArrayPointerSymbol = firstChildSymbol->isInternalPointer() ?
firstChildSymbol->castToInternalPointerAutoSymbol()->getPinningArrayPointer() :
firstChildSymbol->castToAutoSymbol();
}
else if (firstChild->getRegister() &&
firstChild->getRegister()->containsInternalPointer())
{
pinningArrayPointerSymbol = firstChild->getRegister()->getPinningArrayPointer();
}
}
if (pinningArrayPointerSymbol)
{
trgReg->setContainsInternalPointer();
trgReg->setPinningArrayPointer(pinningArrayPointerSymbol);
}
}
0xdaryl
reviewed
Jul 20, 2019
| @@ -612,3 +613,46 @@ OMR::ARM64::TreeEvaluator::lxorEvaluator(TR::Node *node, TR::CodeGenerator *cg) | |||
| // boolean xor of 2 integers | |||
| return genericBinaryEvaluator(node, TR::InstOpCode::eorx, TR::InstOpCode::eorimmx, true, cg); | |||
| } | |||
|
|
|||
| // Also handles TR::aluadd | |||
There was a problem hiding this comment.
Remove comment. TR::aluadd has been deprecated.
This commit implements aladdEvaluator() for AArch64. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
Updated |
|
@genie-omr build aarch64 |
|
Code changes seem fine. I don't fully understand all the implications of compressed references on this evaluator (and if any support is missing) but I think what you have is a good start. |
0xdaryl
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements aladdEvaluator() for AArch64.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com