Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AArch64 and ARMv8 Processor Information #4111

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

aarongraham9
Copy link
Contributor

Implement AArch64 and ARMv8 Processor Information

Signed-off-by: Aaron Graham aaron.graham@unb.ca

@aarongraham9
Copy link
Contributor Author

Thoughts @knn-k and @0xdaryl?

* definitions are permitted.
*/

ARMv8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call it ARMv8_A.
There are some architectures in the ARMv8 family, and our AArch64 target is ARMv8-A.
ARMv8-M, for example, does not support the AArch64 instruction set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Sounds good!

Signed-off-by: Aaron Graham <aaron.graham@unb.ca>
@aarongraham9
Copy link
Contributor Author

Updated ARMv8 -> ARMv8_A based on @knn-k's suggestion; thanks!

@0xdaryl
Copy link
Contributor

0xdaryl commented Jul 9, 2019

@genie-omr build all

@0xdaryl 0xdaryl self-assigned this Jul 10, 2019
@0xdaryl 0xdaryl merged commit d51a93b into eclipse-omr:master Jul 10, 2019
@aarongraham9 aarongraham9 deleted the aarch64_processor branch August 22, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants