Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Enable beginInstructionSelection() for PrivateLinkage #4066

Merged
merged 1 commit into from
Jun 21, 2019
Merged

AArch64: Enable beginInstructionSelection() for PrivateLinkage #4066

merged 1 commit into from
Jun 21, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jun 21, 2019

This commit removes the line "TR_UNIMPLEMENTED();" for TR_Private
from OMR::ARM64::CodeGenerator::beginInstructionSelection().

Signed-off-by: knn-k konno@jp.ibm.com

@knn-k
AArch64: Enable beginInstructionSelection() for PrivateLinkage
3921de6 
This commit removes the line "TR_UNIMPLEMENTED();" for TR_Private
from OMR::ARM64::CodeGenerator::beginInstructionSelection().

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k knn-k requested a review from 0xdaryl as a code owner June 21, 2019 02:30
@knn-k
Copy link
Contributor Author

knn-k commented Jun 21, 2019

The TR_UNIMPLEMENTED(); was there because the beginInstructionSelection() for ARM32 generates one more instruction for JNI methods while the p version does not.
I will revisit it if we need to do anything with JNI methods for AArch64.

@0xdaryl 0xdaryl self-assigned this Jun 21, 2019
@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 21, 2019

@genie-omr build aarch64

@0xdaryl 0xdaryl merged commit 13c674b into eclipse-omr:master Jun 21, 2019
@knn-k knn-k deleted the aarch64codegen5 branch June 21, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees

@0xdaryl 0xdaryl

Labels
arch:aarch64 comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @0xdaryl