Remove RegisterITF references from OMROptions #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonardo2718
suggested changes
Jun 13, 2019
| // Avaialble = 0x00008000, | ||
| TR_TraceRegisterITFBuild = 0x00010000, | ||
| // Available = 0x00020000, | ||
| TR_TraceRegisterITFColour = 0x00040000, |
There was a problem hiding this comment.
The first of these fields (TR_TraceRegisterITFBasic) can be safely removed. However, subsequent ones should stay and be commented out as // Available. This allows us to keep track of which bits are available for future options.
// Avaialble = 0x00008000,
// Avaialble = 0x00010000,
// Available = 0x00020000,
// Avaialble = 0x00040000,| @@ -1049,7 +1049,14 @@ enum TR_CompilationOptions | |||
| // | |||
| TR_TraceLRAResults = 0x00000800, | |||
| // Available = 0x00001000, | |||
|
|
|||
|
|
|||
| // Register ITF tracing option word | |||
There was a problem hiding this comment.
This comment is no longer relevant.
|
@nidhi1605 can you please squash the commits together? |
Fixes eclipse-omr#3961 Signed-off-by: Nidhi Gupta <itsnidhi16@gmail.com>
nidhi1605
force-pushed
the
removeReference
branch
from
46df1d6
to
3bb056b
Compare
|
I have squashed the commits together, @Leonardo2718 could you please review this? |
|
@genie-omr build all |
0xdaryl
approved these changes
Jun 18, 2019
|
@Leonardo2718 , could you sign off on these changes please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3961
Signed-off-by: Nidhi Gupta itsnidhi16@gmail.com