Use symRef with known obj index for known parms #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyzhyi
requested review from
0xdaryl,
Leonardo2718,
mstoodle and
vijaysun-omr
as code owners
andrewcraik
reviewed
Jun 6, 2019
| @@ -130,6 +130,11 @@ class OMR_EXTENSIBLE ResolvedMethodSymbol : public TR::MethodSymbol | |||
|
|
|||
| void addVariableSizeSymbol(TR::AutomaticSymbol *s); | |||
|
|
|||
| /* | |||
| * Get known object index of a parameter if there is any known object information available | |||
There was a problem hiding this comment.
can you describe what slot is and how counting works for a call since OMR is not Java and a slot can be an ambiguous concept...
There was a problem hiding this comment.
Thanks for pointing that out! changed from slot to ordinal and added an explanation.
cathyzhyi
force-pushed
the
parmsymbol
branch
3 times, most recently
from
2776f5c
to
6566179
Compare
If known object information is avaible for the method receiver, use known object index to create the parm symbol reference. Optimizations can make use of the info without running global VP which is very expensive and doesn't kick in at warm. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
andrewcraik
approved these changes
Jun 7, 2019
|
@genie-omr build all |
0xdaryl
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If known object information is avaible for the method receiver, use
known object index to create the parm symbol reference. Optimizations
can make use of the info without running global VP which is very
expensive and doesn't kick in at warm.
Signed-off-by: Yi Zhang yizhang@ca.ibm.com