Ensure local variables are initialized at declaration #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating a crash in eclipse-openj9/openj9#5988, I had to look at the AVL code and there were cases where it wasn't clear all the variables had been initialized before they were read. This patch makes initialization explicit and ensures variables are initialized at their declaration site. This patch is code cleanup to make it easier to reason about the AVL code. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a crash in eclipse-openj9/openj9#5988, I had to
look at the AVL code and there were cases where it wasn't
clear all the variables had been initialized before they
were read. This patch makes initialization explicit and
ensures variables are initialized at their declaration site.
This patch is code cleanup to make it easier to reason about
the AVL code.
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com