Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document purpose of "toolchain bug" label #3896

Merged
merged 1 commit into from
May 29, 2019

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented May 24, 2019

[ci skip]

Signed-off-by: Daryl Maier maier@ca.ibm.com

@0xdaryl
Copy link
Contributor Author

0xdaryl commented May 24, 2019

Maybe this label should be renamed to "toolchain bug" to make it more general???

@nbhuiyan
Copy link
Contributor

I think toolchain bug would be a better name for this label so that it can be used for labelling issues/workarounds for bugs in any other tools used for building/debugging. I don't expect there to be many issues/PRs needing to use the build compiler bug label, so I think a more general label would be more appropriate.

@Leonardo2718
Copy link
Contributor

👍 for toolchain bug as a label.

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl
Copy link
Contributor Author

0xdaryl commented May 24, 2019

OK, latest proposal renames this to "toolchain bug". Of course the link doesn't work because we haven't renamed the label yet, but that's easy to do once there's consensus.

@0xdaryl 0xdaryl changed the title Document purpose of "build compiler bug" label Document purpose of "toolchain bug" label May 24, 2019
@0xdaryl
Copy link
Contributor Author

0xdaryl commented May 28, 2019

if (committer != 0xdaryl) {
   ping();
}

Copy link
Contributor

@Leonardo2718 Leonardo2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Leonardo2718 Leonardo2718 self-assigned this May 29, 2019
@Leonardo2718 Leonardo2718 merged commit aa5e91f into eclipse-omr:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants