Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments around use of ifExcluded option #5243

Open
fjeremic opened this issue May 25, 2020 · 0 comments
Open

Add comments around use of ifExcluded option #5243

fjeremic opened this issue May 25, 2020 · 0 comments
Labels
backlog comp:compiler good first issue help wanted

Comments

@fjeremic
Copy link
Contributor

@dsouzai asked a question on Slack which I quote here for future preservation:

Could someone explain to me what's going on here:
https://github.com/eclipse/omr/blob/ed8b6e2da1e1ac8f2de8d7665ac747caa37b5592/compiler/ras/LimitFile.cpp#L1324-L1334
why would we want to say an excluded method should be compiled?

to which @andrewcraik provided a very useful answer:

that is a debugging aid - if you have a failure that is timing sensitive dropping opt levels can make problems go away. The -Xjit:ifExcluded() option allows you to set options for the excluded methods - eg set them to noOpt or whatever
this is super useful for optimization bugs

We should at the least put a comment in the code around the code in question to explain why the code is doing what it is doing based on the above explanation so that future readers are not puzzled.

[1] https://eclipse-omr.slack.com/archives/C33J7UAER/p1589994945160300
patilca added a commit to patilca/omr that referenced this issue Jun 1, 2020
@patilca
Update comment to add more context that excluded methods are compiled…
e0d2755 
… if -Xjit:ifExcluded() option is specified

Issue eclipse-omr#5243
Signed-off-by: Kishor Patil <patil@ca.ibm.com>
@patilca patilca mentioned this issue Jun 1, 2020
Merged
patilca added a commit to patilca/omr that referenced this issue Jun 2, 2020
@patilca
Use spaces instead of tabs in the comment
9baa814 
Issue eclipse-omr#5243
Signed-off-by: Kishor Patil <patil@ca.ibm.com>
patilca added a commit to patilca/omr that referenced this issue Jun 3, 2020
@patilca
Update comment when excluded methods are compiled
f58aeb7 
Issue eclipse-omr#5243
Signed-off-by: Kishor Patil<patil@ca.ibm.com>
kbeaton2-UNB3035 pushed a commit to CAS-Atlantic/omr that referenced this issue Jun 23, 2020
@patilca @kbeaton2-UNB3035
Update comment when excluded methods are compiled
b911b54 
Issue eclipse-omr#5243
Signed-off-by: Kishor Patil<patil@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog comp:compiler good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjeremic @0xdaryl