Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move supportsTrapsInTMRegion to OpenJ9 #1868

Closed
0xdaryl opened this issue Oct 26, 2017 · 0 comments · Fixed by #3928
Closed

Move supportsTrapsInTMRegion to OpenJ9 #1868

0xdaryl opened this issue Oct 26, 2017 · 0 comments · Fixed by #3928
Labels
backlog comp:compiler good first issue help wanted

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 26, 2017

The OMR::CodeGenerator function supportsTrapsInTMRegion is not used in OMR. Relocate it to the OpenJ9 project's J9::CodeGenerator and remove it from OMR.
wbh123456 added a commit to wbh123456/omr that referenced this issue May 29, 2019
@wbh123456
Remove supportsTrapsInTMRegion from OMR
4197e85 
Remove all the references to supportsTrapsInTMRegion from OMR as the
field has already been transferred to  OpenJ9.

Closes: eclipse-omr#1868
Signed-off-by: Bohao(Aaron) Wang <aaronwang0407@gmail.com>
@wbh123456 wbh123456 mentioned this issue May 29, 2019
Merged
wbh123456 added a commit to wbh123456/omr that referenced this issue May 29, 2019
@wbh123456
Remove supportsTrapsInTMRegion from OMR
8f44c05 
Remove all the references to supportsTrapsInTMRegion from OMR as the
field has already been transferred to  OpenJ9.

Closes: eclipse-omr#1868
Signed-off-by: Bohao(Aaron) Wang <aaronwang0407@gmail.com>
@wbh123456 wbh123456 mentioned this issue May 29, 2019
Merged
wbh123456 added a commit to wbh123456/openj9 that referenced this issue May 30, 2019
@wbh123456
Duplicate supportsTrapsInTMRegion to OpenJ9
f218292 
Duplicates all the declarations and definitions of
supportsTrapsInTMRegion from OMR::CodeGenerator to J9::CodeGenerator

Issue: eclipse-omr/omr#1868
Signed-off-by: Bohao(Aaron) Wang <aaronwang0407@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog comp:compiler good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove supportsTrapsInTMRegion from OMR wbh123456/omr
1 participant
@0xdaryl