Eclipse Marketplace doesn't respond to mouse clicks on macOS after missing project facet popup

[kgibm]

Let's make sure issue is not already fixed in latest builds first.

• I tried to reproduce this issue against the latest Integration Build of Eclipse SDK after installing https://download.eclipse.org/technology/m2e/snapshots/latest/ but I don't get the missing project facet popup so I'm not sure what else I need to try to reproduce

Steps to reproduce

From a fresh installation and clean workspace:

1. Download Eclipse IDE for Eclipse Committers 2024-12
2. Clone Eclipse MAT source:

   git clone https://github.com/eclipse-mat/mat
   

3. File } Import... } General } Existing Projects into Workspace } Select your cloned MAT source directory
4. A popup comes up for Marketplace solutions available:
   
5. Click Show Solutions
6. The Eclipse Marketplace popup comes up but I can't interact with it. Trying to click on it sends it to the back of all windows. I can only interact with the Marketplace solutions available popup.

Video:

Screen.Recording.2025-02-11.at.7.39.46.AM.mp4

I expected: The second popup to work

But got: The second popup doesn't work

Here is some relevant log output

From <workspace>/.metadata/.log

!SESSION 2025-02-11 07:37:51.952 -----------------------------------------------
eclipse.buildId=4.34.0.20241128-0756
java.version=21.0.5
java.vendor=Eclipse Adoptium
BootLoader constants: OS=macosx, ARCH=aarch64, WS=cocoa, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.committers.product -keyring /Users/kevin/.eclipse_keyring
Command-line arguments:  -os macosx -ws cocoa -arch aarch64 -product org.eclipse.epp.package.committers.product -keyring /Users/kevin/.eclipse_keyring

!ENTRY org.eclipse.oomph.setup.ui 1 0 2025-02-11 07:38:33.536
!MESSAGE Setup tasks were performed during startup updating 1 preference. See '/Users/kevin/work/mat/Eclipse.app/Contents/Eclipse/configuration/org.eclipse.oomph.setup/setup.log' for details

Tested under this environment:

• OS & version: macOS Sequoia 15.2
• Eclipse IDE/Platform version (as shown in Help > About): 2024-12 (4.34.0)

$ system_profiler SPSoftwareDataType SPHardwareDataType | grep -v -e UUID -e UDID -e 'User Name' -e 'Computer Name' -e Serial
Software:

    System Software Overview:

      System Version: macOS 15.2 (24C101)
      Kernel Version: Darwin 24.2.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Secure Virtual Memory: Enabled
      System Integrity Protection: Disabled
      Time since boot: 24 minutes, 10 seconds

Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: Mac14,10
      Model Number: Z1740017JLL/A
      Chip: Apple M2 Pro
      Total Number of Cores: 12 (8 performance and 4 efficiency)
      Memory: 32 GB
      System Firmware Version: 11881.61.3
      OS Loader Version: 11881.61.3
      Activation Lock Status: Disabled

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[kgibm]

Ed mentioned:

The dialog is opened by this logic:

epp.mpc/org.eclipse.epp.mpc.ui/src/org/eclipse/epp/internal/mpc/ui/discovery/ShowNatureProposalsJob.java

Line 55 in 9b1d3e7

marketplaceClientService.open(config, allNodes);

Maybe this is computing the wrong parent shell:

epp.mpc/org.eclipse.epp.mpc.ui/src/org/eclipse/epp/internal/mpc/ui/commands/MarketplaceWizardCommand.java

Lines 121 to 127 in 9b1d3e7

	protected MarketplaceWizardDialog createWizardDialog(DiscoveryWizard wizard, ExecutionEvent event) {
	Shell activeShell = HandlerUtil.getActiveShell(event);
	if (activeShell == null) {
	activeShell = WorkbenchUtil.getShell();
	}
	return new MarketplaceWizardDialog(activeShell, (MarketplaceWizard) wizard);
	}

Or it's create a shell with the wrong style...