No wait on immediate bridge reload #2926
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiliojr
force-pushed
the
no_wait_immediate
branch
from
ecb7c0e to
ca8a139
Compare
ralight
force-pushed
the
develop
branch
3 times, most recently
from
028adb2 to
604b69a
Compare
Currently bridge connections will backoff even when set to immediate. This change makes the first attempt to reconnect happen without wait. On failure, backoff will apply as usual. Signed-off-by: Abilio Marques <abiliojr@gmail.com>
abiliojr
force-pushed
the
no_wait_immediate
branch
from
ca8a139 to
587b105
Compare
ralight
force-pushed
the
develop
branch
3 times, most recently
from
b7e2d3d to
e715b04
Compare
ralight
force-pushed
the
develop
branch
2 times, most recently
from
ae502fb to
9b6f004
Compare
ralight
force-pushed
the
develop
branch
4 times, most recently
from
b612b85 to
93557bf
Compare
ralight
force-pushed
the
develop
branch
2 times, most recently
from
6b404a7 to
2c4967a
Compare
ralight
force-pushed
the
develop
branch
8 times, most recently
from
ef94231 to
be592cc
Compare
ralight
force-pushed
the
develop
branch
4 times, most recently
from
74cc684 to
fd0fa72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are 2 kinds of bridge configuration reload: lazy and immediate. According to the readme, immediate "forces a reconnection and so uses the new configuration straight away", but the current implementation first backs off. This pull request skips that first backoff.
make testwith your changes locally?