New Client Subscription and MonitoredItem API #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new client Subscription and MonitoredItem API.
The original implementation (
OpcUaSubscriptionManager,OpcUaSubscription,OpcUaMonitoredItem) is functional but has a difficult to use asynchronous/non-blocking API.The "Managed" API was built on top of that, in an attempt to provide an easier to use API, but neither API properly addresses the race condition that exists between creation of a MonitoredItem and hooking up a listener.
Between the 2 implementations there's something like 8 listener interfaces at this point.
This new API is a fresh start that provides an easy to use synchronous/blocking API, fixes the race conditions, and provides a sane set of callbacks to to implement. It also takes care of batching using the server operation limits when creating, modifying, and deleting monitored items or when changing the monitoring mode.