Add AST viewer to Langium VSCode extension - #2185
Open
gfontorbe wants to merge 6 commits into
Open
Conversation
gfontorbe
changed the title
gfontorbe
force-pushed
the
gfontorbe/inspector
branch
from
July 10, 2026 11:43
05945f6 to
6d9d0b5
Compare
gfontorbe
changed the title
spoenemann
reviewed
Jul 20, 2026
spoenemann
left a comment
spoenemann
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a detail
| async function registerInspector(client: LanguageClient, languageId: string): Promise<vscode.Disposable> { | ||
| const vscodeApi = await import('vscode'); | ||
| try { | ||
| await vscodeApi.commands.executeCommand('langium-inspector.register', client, languageId); |
Contributor
There was a problem hiding this comment.
Is this missing a return? Otherwise we always return a disposable that does nothing.
Contributor
Author
There was a problem hiding this comment.
It's missing the unregistration logic completely. Fixing that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a treeview contribution to the Langium VSCode extension to display the opened document's AST.