Clean up invalid projects during the initialized phase#3208
Merged
snjeza merged 1 commit intoeclipse-jdtls:masterfrom Jul 20, 2024
Merged
Clean up invalid projects during the initialized phase#3208snjeza merged 1 commit intoeclipse-jdtls:masterfrom
snjeza merged 1 commit intoeclipse-jdtls:masterfrom
Conversation
Contributor
Author
|
test this please |
Contributor
|
This definitely seems to fix the issue! I just want to test it out a little more. |
rgrunber
reviewed
Jul 17, 2024
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
rgrunber
reviewed
Jul 19, 2024
org.eclipse.jdt.ls.tests/projects/maven/invalid2/module1/pom.xml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@rgrunber I have updated the PR. |
rgrunber
approved these changes
Jul 19, 2024
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
I would rename the commit to something like : Clean up invalid projects during the initialized phase.
Feel free to merge when ready.
snjeza
changed the title
Contributor
Author
|
test this please |
1 similar comment
Contributor
Author
|
test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#3639
Test vsix - VS Code 1.34.0