Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new aliases for sysout and syserr snippets #2927

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add new aliases for sysout and syserr snippets #2927

merged 1 commit into from
Oct 25, 2023

Conversation

hopehadfield
Copy link
Contributor

Implements solution proposed in #2918 (comment).

Screenshot from 2023-10-25 11-32-10

@hopehadfield
Add new aliases for sysout and syserr snippets
485a221 
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
rgrunber
rgrunber approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the test. I think it exposes some more weird cases we'll need to investigate for matchCase at a later point.

@hopehadfield hopehadfield mentioned this pull request Oct 25, 2023
Merged
@rgrunber rgrunber merged commit 7f75fbb into eclipse-jdtls:master Oct 25, 2023
4 checks passed
@testforstephen testforstephen mentioned this pull request Oct 26, 2023
Merged
@hopehadfield hopehadfield deleted the print-aliases branch October 26, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopehadfield @rgrunber