F2 rename of Lombok @Singular attribute does nothing

[snjeza]

Fixes redhat-developer/vscode-java#3203

[snjeza]

test this please

[snjeza]

test this please

[snjeza]

retest this please.

@rgrunber This PR is not ready yet.

[snjeza]

@rgrunber I have updated the PR. It is ready.

[rgrunber]

This looks fine. I remember a very similar issue so wanted to track it down. It's #1561 .

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ReferencesHandler.java

Lines 77 to 81 in 847f305

	IJavaElement elementToSearch = JDTUtils.findElementAtSelection(typeRoot, param.getPosition().getLine(), param.getPosition().getCharacter(), this.preferenceManager, monitor);
	if (elementToSearch == null) {
	int offset = JsonRpcHelpers.toOffset(typeRoot.getBuffer(), param.getPosition().getLine(), param.getPosition().getCharacter());
	elementToSearch = typeRoot.getElementAt(offset);
	}

Is the code inside the if statement still necessary if we're moving the logic into JDTUtils#findElementAtSelection(..) ?

[snjeza]

Is the code inside the if statement still necessary if we're moving the logic into JDTUtils#findElementAtSelection(..) ?

Yes, it is. See 8ba5bee#diff-38af31aa96ae8ee1debae74bf388b43dea8891646b1032ecdb2f4a7ea3e06f8cR1011

[snjeza]

test this please