Skip to content

Update org.eclipse.jdt.ls.tp.target to use m2e snapshot - #2563

Merged
Eskibear merged 2 commits into
masterfrom
yanzh/mvn391
Mar 31, 2023
Merged

Update org.eclipse.jdt.ls.tp.target to use m2e snapshot#2563
Eskibear merged 2 commits into
masterfrom
yanzh/mvn391

Conversation

@Eskibear

Copy link
Copy Markdown
Contributor

Maven 3.9.1 is embedded in latest m2e snapshot build, which enables jdtls to resolve dependencies in parallel.

@Eskibear

Copy link
Copy Markdown
Contributor Author

See eclipse-m2e/m2e-core#1169 (comment) and eclipse-m2e/m2e-core#1238

@rgrunber rgrunber added this to the Early April 2023 milestone Mar 30, 2023
@rgrunber

rgrunber commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Looks like the next release would be 2.3.0 (I don't think 2.2.2 would have the change), which is fine. Just wanted to confirm we aren't moving to a snapshot of something that will be 3.x, as that might force us to have to adapt to a lot more breaking changes.

@Eskibear

Copy link
Copy Markdown
Contributor Author

Yes, now snapshots/latest points to snapshots/2.3.0. In order not to wrongly use 3.x, I thought we would switch to releases/2.3.0 once it's released. Do you want me to explicitly change it to 2.3.0? I'm ok with both.

@rgrunber rgrunber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually yes, that's probably better to do. Just use snapshots/2.3.0/. Once that's in, feel free to merge.

@Eskibear
Eskibear merged commit 2f15305 into master Mar 31, 2023
@Eskibear
Eskibear deleted the yanzh/mvn391 branch March 31, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants