Ease integration in Eclipse IDE #2423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2023
mickaelistria
force-pushed
the
eclipse-flag
branch
from
b686a6f to
80eefcd
Compare
mickaelistria
force-pushed
the
eclipse-flag
branch
from
80eefcd to
d63329f
Compare
|
test this please |
mickaelistria
force-pushed
the
eclipse-flag
branch
from
d63329f to
7f23ad7
Compare
mickaelistria
added a commit
to redhat-developer/eclipseide-jdtls
that referenced
this pull request
Feb 1, 2023
* use flag proposed in eclipse-jdtls/eclipse.jdt.ls#2423 to prevent undesired "echo" of changes, markers, logs * Added requirements to m2e and buildship to workaround eclipse-jdtls/eclipse.jdt.ls#2429 * Updated TP to newer versions * Updated Tycho version * Currently added jdt-ls in same build as submodules to be able to used the "good" branch, compatible with Eclipse IDE, ie including ** eclipse-jdtls/eclipse.jdt.ls#2423 and ** eclipse-jdtls/eclipse.jdt.ls#2417
mickaelistria
force-pushed
the
eclipse-flag
branch
3 times, most recently
from
f4ea193 to
ff47a1e
Compare
When running in Eclipse IDE workbench: * didChange won't forward TextEdit to underlying resource model * Eclipse Log forwarding from LS to Eclipse IDE is disabled * Markers forwarding from LS to Eclipse IDE disabled * Don't forward workspace folders, don't cleanup workspace
mickaelistria
force-pushed
the
eclipse-flag
branch
from
ff47a1e to
4dc25f4
Compare
|
In this new version of the patch, the flag is removed and instead JDT-LS detects that it is running with the Eclipse workbench. So no flag is necessary any more. |
|
After a discussion with @rgrunber , we'll refactor it:
I'll make separate patches for each. |
|
I'm closing this one in favor of the 4 other patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to be set by client to declare it's Eclipse IDE. When true: