Use ASTProvider to getAST for source action handlers #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
fbricon
requested changes
Aug 26, 2020
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java
Outdated
Show resolved
Hide resolved
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateConstructorsHandler.java
Show resolved
Hide resolved
|
test this please |
|
There are 2 failures on Jenkins with this PR: I can reproduce them on my linux box and my mac |
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
|
Thanks @testforstephen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
ASTProvider will cache the AST node for the active editor, should use it whenever possible.
Below is the profiling comparison on editing a Java file with 200 LOC.
Before:
The source action handlers will parse a new AST every time in the source action handler. Most of time of getSourceActionCommands is on parsing AST node. And the time ratio between getSourceActionCommands and getCodeActionCommands is about 64%.
After:
Use ASTProvider to get AST node, and the time ratio reduces to 40%.