-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#490] Enable loan_slice APIs in CXX bindings #492
[#490] Enable loan_slice APIs in CXX bindings #492
Conversation
515c63a
to
a970c4d
Compare
a4d05bb
to
a450cc8
Compare
1da7cbd
to
1468900
Compare
7617565
to
0cf2c2b
Compare
594f3bb
to
7d4daa7
Compare
7d4daa7
to
91f3cf2
Compare
91f3cf2
to
1a8a87e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found another issue with the Slice
I overlooked in the previous reviews. We need to introduce a ConstIterator
so that the user does not change the const MutableSlice
content by accident when they iterate over the slice elements.
52a2a4b
to
23b5be2
Compare
23b5be2
to
b353e0a
Compare
7ae92fd
to
636e199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Rust example is adjusted we can merge it
Notes for Reviewer
iox::Slice
loan_slice
APIs in C++ bindingpayload_alignment
andmax_slice_len
in C++ bindingPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #490