-
Notifications
You must be signed in to change notification settings - Fork 102
[#154] Separate logger frontend and backend #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orecham
wants to merge
24
commits into
eclipse-iceoryx:main
Choose a base branch
from
ekxide:iox2-154-separate-logger-frontend-and-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[#154] Separate logger frontend and backend #1224
orecham
wants to merge
24
commits into
eclipse-iceoryx:main
from
ekxide:iox2-154-separate-logger-frontend-and-backend
+1,668
−852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d610ff to
5f0689e
Compare
976f6c2 to
2664257
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 78.39% 78.17% -0.22%
==========================================
Files 410 412 +2
Lines 40988 41001 +13
Branches 1093 1117 +24
==========================================
- Hits 32131 32051 -80
- Misses 8026 8094 +68
- Partials 831 856 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
elfenpiff
reviewed
Dec 8, 2025
a4bc24e to
82f4eb0
Compare
9da8a5f to
81d277b
Compare
81d277b to
46e87d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
NOTE: THE APPROACH HAS BEEN MODIFIED SINCE INITIAL SUBMISSION
This PR separates the logging API and logger implementation into separate crates:
iceoryx2-log- front-end logging APIiceoryx2-loggers- back-end logger implementationsThe default logging implementation can be selected via feature flags (e.g.
logger_console). Only one default logger can be selected at any time. The default logger is automatically used if there are no other loggers set at runtime.All binaries are required to link to the
iceoryx2_loggerscrate somehow.This is automatically done when using the
iceoryx2crate as a dependency, however if using any other crate in the workspace separately, this must be handled manually by adding dependency toiceoryx2_loggersand specifying the following to ensure the crate is linked even when not directly used:Previous Version
Users are required to explicitly select and set their desired logger implementation at runtime:
This change sets up the foundation for:
iceoryx2crates, includingiceoryx2-pal-posixiceoryx2-bb-posixto support logging on all POSIX platforms, even if they areno_stdPre-Review Checklist for the PR Author
iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)PR Reviewer Reminders
References
Relates #154