Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 3, 2025

Notes for Reviewer

This PR moves the legacy::function to bb::StaticFunction

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • [~] Tests follow the best practice for testing
  • [~] Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Relates to #301

@elBoberido elBoberido force-pushed the iox2-301-move-function-files-to-iox2-bb branch 2 times, most recently from d610be8 to b2cc07d Compare December 3, 2025 23:00
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 89.34426% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.33%. Comparing base (d8f29d4) to head (f0af4aa).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...-bb/cxx/include/iox2/bb/detail/static_function.hpp 88.57% 0 Missing and 12 partials ⚠️
.../cxx/include/iox2/legacy/cli/option_definition.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   78.32%   78.33%           
=======================================
  Files         413      410    -3     
  Lines       41023    40974   -49     
  Branches     1117     1113    -4     
=======================================
- Hits        32132    32095   -37     
+ Misses       8035     8025   -10     
+ Partials      856      854    -2     
Flag Coverage Δ
CPP 72.25% <89.34%> (-0.15%) ⬇️
Rust 78.17% <91.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/cxx/include/iox2/legacy/string.hpp 100.00% <ø> (ø)
...yx2-cxx/include/iox2/internal/callback_context.hpp 51.85% <100.00%> (ø)
iceoryx2-cxx/include/iox2/listener.hpp 64.17% <100.00%> (ø)
iceoryx2-cxx/include/iox2/node.hpp 100.00% <ø> (ø)
iceoryx2-cxx/include/iox2/node_state.hpp 66.66% <ø> (ø)
...oryx2-cxx/include/iox2/port_factory_blackboard.hpp 66.66% <ø> (ø)
...xx/include/iox2/port_factory_publish_subscribe.hpp 67.50% <ø> (ø)
...cxx/include/iox2/port_factory_request_response.hpp 69.04% <ø> (ø)
iceoryx2-cxx/include/iox2/request_mut_uninit.hpp 87.50% <ø> (ø)
iceoryx2-cxx/include/iox2/response_mut_uninit.hpp 86.66% <ø> (ø)
... and 14 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido changed the base branch from main to iox2-301-replace-hoofs-vector-with-new-static-vector December 5, 2025 00:18
@elBoberido elBoberido force-pushed the iox2-301-move-function-files-to-iox2-bb branch from b2cc07d to 5e9e2d4 Compare December 5, 2025 00:18
Base automatically changed from iox2-301-replace-hoofs-vector-with-new-static-vector to main December 5, 2025 14:22
@elBoberido elBoberido force-pushed the iox2-301-move-function-files-to-iox2-bb branch from 5e9e2d4 to 20645bc Compare December 5, 2025 14:24
@elBoberido elBoberido changed the title [Stacked PR] [Based on #1216] [#301] Move 'function' files to 'iox2/bb' [#301] Move 'function' files to 'iox2/bb' Dec 5, 2025
@elBoberido elBoberido marked this pull request as draft December 5, 2025 14:26
@elBoberido elBoberido marked this pull request as ready for review December 5, 2025 14:26
@elfenpiff elfenpiff self-requested a review December 8, 2025 15:35
@elBoberido elBoberido force-pushed the iox2-301-move-function-files-to-iox2-bb branch from 20645bc to 35f37df Compare December 8, 2025 16:58
@elBoberido elBoberido force-pushed the iox2-301-move-function-files-to-iox2-bb branch from faeb6dc to f0af4aa Compare December 8, 2025 22:51
@elBoberido elBoberido requested a review from elfenpiff December 9, 2025 01:36
@elBoberido elBoberido merged commit 2065e99 into main Dec 9, 2025
60 checks passed
@elBoberido elBoberido deleted the iox2-301-move-function-files-to-iox2-bb branch December 9, 2025 14:14
@elBoberido elBoberido linked an issue Dec 9, 2025 that may be closed by this pull request
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move iceoryx_hoofs subset to iceoryx2

3 participants