Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Move FreeBSD back to GitHub actions #2257

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 15, 2024

Notes for Reviewer

In order to safe credits on Cirrus CI, the FreeBSD build is moved back to github.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Apr 15, 2024
@elBoberido elBoberido added the tooling All iceoryx related tooling (scripts etc.) label Apr 15, 2024
@elBoberido elBoberido marked this pull request as ready for review April 15, 2024 15:56
@elBoberido elBoberido requested a review from elfenpiff April 15, 2024 15:56
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (688c95f) to head (8abf97d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2257       +/-   ##
===========================================
+ Coverage   14.97%   78.11%   +63.14%     
===========================================
  Files         432      432               
  Lines       15894    15894               
  Branches     2297     2297               
===========================================
+ Hits         2380    12416    +10036     
+ Misses      13197     2631    -10566     
- Partials      317      847      +530     
Flag Coverage Δ
unittests 77.94% <ø> (?)
unittests_timing 14.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 346 files with indirect coverage changes

elfenpiff
elfenpiff previously approved these changes Apr 15, 2024
@elBoberido elBoberido dismissed elfenpiff’s stale review April 15, 2024 16:05

The merge-base changed after approval.

@elBoberido elBoberido requested a review from elfenpiff April 15, 2024 19:25
@elBoberido elBoberido force-pushed the iox-2011-move-freebsd-back-to-github-actions branch from 8194801 to 8abf97d Compare April 15, 2024 20:15
@elBoberido elBoberido merged commit ad027aa into eclipse-iceoryx:master Apr 15, 2024
24 of 25 checks passed
@elBoberido elBoberido deleted the iox-2011-move-freebsd-back-to-github-actions branch April 15, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants