Skip to content

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Mar 14, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1939 (c8ccd0e) into master (a7d1e85) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
- Coverage   75.40%   75.38%   -0.02%     
==========================================
  Files         386      386              
  Lines       15200    15200              
  Branches     2147     2147              
==========================================
- Hits        11461    11458       -3     
  Misses       3068     3068              
- Partials      671      674       +3     
Flag Coverage Δ
unittests 75.03% <ø> (-0.02%) ⬇️
unittests_timing 15.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido
Copy link
Member

Can you please replace the https://tools.ietf.org/id/draft-cotton-tsvwg-iana-ports-00.html#privateports link with https://datatracker.ietf.org/doc/id/draft-cotton-tsvwg-iana-ports-00.html#privateports in doc/design/chunk_header.md

Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have you checked if the readme needs to be updated?

@elfenpiff
Copy link
Contributor Author

@FerdinandSpitzschnueffler

LGTM but have you checked if the readme needs to be updated?

I checked it and the readme does not require any update. I just changed the technology implementation for send/receive for uds and mq which does not imply any change in the public or even private API.
Only the benchmark numbers are now fair.

@elfenpiff elfenpiff merged commit f42c003 into eclipse-iceoryx:master Mar 15, 2023
@elfenpiff elfenpiff deleted the iox-1938-fix-unfair-iceperf branch March 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iceperf: comparing iceoryx busy loop with uds, mq push is unfair.
3 participants