Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-1394 fix axivion warnings for multiple files #1896

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Feb 14, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added AUTOSAR Warning of an Adpative Autosar C++14 rule Axivion Related to Axivion Suite from Axivion labels Feb 14, 2023
@elBoberido elBoberido self-assigned this Feb 14, 2023
@elBoberido elBoberido force-pushed the iox-1394-fix-axivion-warnings-for-multiple-files branch 2 times, most recently from f9bd109 to 0a9b591 Compare February 14, 2023 20:48
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1896 (19784fa) into master (f4c81ab) will decrease coverage by 0.01%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
- Coverage   75.44%   75.44%   -0.01%     
==========================================
  Files         383      383              
  Lines       15173    15181       +8     
  Branches     2148     2148              
==========================================
+ Hits        11447    11453       +6     
  Misses       3055     3055              
- Partials      671      673       +2     
Flag Coverage Δ
unittests 75.10% <97.72%> (-0.01%) ⬇️
unittests_timing 15.42% <40.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...design/include/iox/detail/functional_interface.inl 95.12% <ø> (ø)
...ryx_hoofs/include/iceoryx_hoofs/cxx/attributes.hpp 100.00% <ø> (ø)
.../include/iceoryx_hoofs/memory/relative_pointer.inl 96.59% <ø> (ø)
...include/iceoryx_hoofs/posix_wrapper/posix_call.hpp 100.00% <ø> (ø)
iceoryx_hoofs/primitives/include/iox/size.hpp 100.00% <ø> (ø)
...osh/internal/popo/building_blocks/chunk_sender.hpp 100.00% <ø> (ø)
...oryx_posh/internal/popo/ports/server_port_user.hpp 100.00% <ø> (ø)
iceoryx_hoofs/time/include/iox/detail/duration.inl 94.11% <94.73%> (-0.42%) ⬇️
...e/iceoryx_dust/internal/cxx/std_string_support.inl 100.00% <100.00%> (+25.00%) ⬆️
...oryx_hoofs/include/iceoryx_hoofs/cxx/algorithm.hpp 92.85% <100.00%> (ø)
... and 20 more

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, few findings.

@elBoberido elBoberido merged commit 697adc9 into eclipse-iceoryx:master Feb 15, 2023
@elBoberido elBoberido deleted the iox-1394-fix-axivion-warnings-for-multiple-files branch February 15, 2023 18:42
@elBoberido elBoberido linked an issue Feb 15, 2023 that may be closed by this pull request
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AUTOSAR Warning of an Adpative Autosar C++14 rule Axivion Related to Axivion Suite from Axivion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address Autosar Violations using Axivion
3 participants