Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1391 Fix legacy build when using unique_ptr #1762

Merged

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Oct 26, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

  • Fix legacy build when using unique_ptr

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Oct 26, 2022
@mossmaurice mossmaurice self-assigned this Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1762 (9d1ed08) into master (8f6af2f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   77.37%   77.35%   -0.03%     
==========================================
  Files         366      366              
  Lines       14187    14187              
  Branches     1983     1983              
==========================================
- Hits        10977    10974       -3     
- Misses       2583     2584       +1     
- Partials      627      629       +2     
Flag Coverage Δ
unittests 77.00% <ø> (-0.03%) ⬇️
unittests_timing 15.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-8.58%) ⬇️

@mossmaurice mossmaurice merged commit 3cbc214 into eclipse-iceoryx:master Oct 26, 2022
@mossmaurice mossmaurice deleted the iox-1391-fix-legacy-build branch October 26, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split iceoryx_hoofs into logical modules
3 participants