-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#831 Replace std::function
with cxx::function
#1411
Merged
mossmaurice
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#831-replace-std-function
Jun 22, 2022
Merged
iox-#831 Replace std::function
with cxx::function
#1411
mossmaurice
merged 5 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#831-replace-std-function
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… value Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice
commented
Jun 22, 2022
mossmaurice
force-pushed
the
iox-#831-replace-std-function
branch
from
June 22, 2022 14:00
cb6680c
to
ec2fc7c
Compare
…val and clang-format Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice
force-pushed
the
iox-#831-replace-std-function
branch
from
June 22, 2022 14:05
ec2fc7c
to
918b64b
Compare
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
elfenpiff
previously approved these changes
Jun 22, 2022
elBoberido
previously approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ... this won't close #831 since the MethodCallback
also needs to be removed
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
==========================================
- Coverage 78.78% 78.69% -0.09%
==========================================
Files 375 379 +4
Lines 14555 14707 +152
Branches 2030 2050 +20
==========================================
+ Hits 11467 11574 +107
- Misses 2427 2467 +40
- Partials 661 666 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
elBoberido
approved these changes
Jun 22, 2022
elfenpiff
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
std::function
withcxx::function
GenericRAII
a template to be able to change the capacity for the cleanup callableChecklist for the PR Reviewer
Post-review Checklist for the PR Author
References
cxx::function
were it is appropriate #831 (partly)