Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#831 Replace std::function with cxx::function #1411

Merged

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Jun 22, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

  • Replace std::function with cxx::function
  • Make GenericRAII a template to be able to change the capacity for the cleanup callable

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… value

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Jun 22, 2022
@mossmaurice mossmaurice self-assigned this Jun 22, 2022
@mossmaurice mossmaurice force-pushed the iox-#831-replace-std-function branch from cb6680c to ec2fc7c Compare June 22, 2022 14:00
…val and

clang-format

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the iox-#831-replace-std-function branch from ec2fc7c to 918b64b Compare June 22, 2022 14:05
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
elfenpiff
elfenpiff previously approved these changes Jun 22, 2022
elBoberido
elBoberido previously approved these changes Jun 22, 2022
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... this won't close #831 since the MethodCallback also needs to be removed

@mossmaurice mossmaurice removed the request for review from MatthiasKillat June 22, 2022 14:31
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1411 (fc13bdc) into master (c8f2f47) will decrease coverage by 0.08%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   78.78%   78.69%   -0.09%     
==========================================
  Files         375      379       +4     
  Lines       14555    14707     +152     
  Branches     2030     2050      +20     
==========================================
+ Hits        11467    11574     +107     
- Misses       2427     2467      +40     
- Partials      661      666       +5     
Flag Coverage Δ
unittests 78.36% <92.59%> (-0.09%) ⬇️
unittests_timing 15.08% <48.14%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/active_object.cpp 0.00% <0.00%> (ø)
...posh/include/iceoryx_posh/runtime/posh_runtime.hpp 100.00% <ø> (ø)
...nclude/iceoryx_hoofs/internal/cxx/generic_raii.inl 96.15% <96.15%> (ø)
...six_wrapper/shared_memory_object/shared_memory.cpp 63.03% <0.00%> (-1.71%) ⬇️
...oofs/source/posix_wrapper/shared_memory_object.cpp 83.56% <0.00%> (-0.65%) ⬇️
iceoryx_hoofs/source/posix_wrapper/semaphore.cpp 69.92% <0.00%> (-0.23%) ⬇️
iceoryx_hoofs/source/file_reader/file_reader.cpp 71.42% <0.00%> (ø)
...eoryx_posh/source/popo/ports/client_port_roudi.cpp 95.04% <0.00%> (ø)
.../include/iceoryx_hoofs/posix_wrapper/semaphore.hpp 100.00% <0.00%> (ø)
...linux/include/iceoryx_hoofs/platform/semaphore.hpp 100.00% <0.00%> (ø)
... and 9 more

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice dismissed stale reviews from elBoberido and elfenpiff via fc13bdc June 22, 2022 14:46
@mossmaurice mossmaurice requested a review from elfenpiff June 22, 2022 16:15
@mossmaurice mossmaurice merged commit 3336313 into eclipse-iceoryx:master Jun 22, 2022
@mossmaurice mossmaurice deleted the iox-#831-replace-std-function branch June 22, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cxx::function were it is appropriate
3 participants