Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#971 Remove success output in shared memory object #1317

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 5, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1317 (1d5e2e6) into master (c41c8cd) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   78.99%   78.96%   -0.03%     
==========================================
  Files         374      374              
  Lines       14687    14683       -4     
  Branches     2051     2052       +1     
==========================================
- Hits        11602    11595       -7     
- Misses       2411     2412       +1     
- Partials      674      676       +2     
Flag Coverage Δ
unittests 78.20% <75.00%> (+<0.01%) ⬆️
unittests_timing 15.45% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oofs/source/posix_wrapper/shared_memory_object.cpp 81.57% <75.00%> (-0.93%) ⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp 64.68% <0.00%> (-1.71%) ⬇️
...nternal/relocatable_pointer/pointer_repository.inl 88.63% <0.00%> (+2.27%) ⬆️

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff force-pushed the iox-#971-shared-memory-abstraction-silent-on-success branch from 0cdd3eb to 837578d Compare April 5, 2022 13:34
@@ -115,7 +115,6 @@ SharedMemoryObject::SharedMemoryObject(const SharedMemory::Name_t& name,

if (m_isInitialized && m_sharedMemory->hasOwnership())
{
std::clog << "Reserving " << m_memorySizeInBytes << " bytes in the shared memory [" << name << "]" << std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this at least as LogDebug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, just for you :D

…rror instead cout/clog/cerr in shared memory object

Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff requested a review from elBoberido April 5, 2022 14:39
@elfenpiff elfenpiff merged commit 6dd7123 into eclipse-iceoryx:master Apr 6, 2022
@elfenpiff elfenpiff deleted the iox-#971-shared-memory-abstraction-silent-on-success branch April 6, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

posix wrapper should be silent on success
3 participants