-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#971 Remove success output in shared memory object #1317
iox-#971 Remove success output in shared memory object #1317
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
- Coverage 78.99% 78.96% -0.03%
==========================================
Files 374 374
Lines 14687 14683 -4
Branches 2051 2052 +1
==========================================
- Hits 11602 11595 -7
- Misses 2411 2412 +1
- Partials 674 676 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
0cdd3eb
to
837578d
Compare
@@ -115,7 +115,6 @@ SharedMemoryObject::SharedMemoryObject(const SharedMemory::Name_t& name, | |||
|
|||
if (m_isInitialized && m_sharedMemory->hasOwnership()) | |||
{ | |||
std::clog << "Reserving " << m_memorySizeInBytes << " bytes in the shared memory [" << name << "]" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have this at least as LogDebug
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, just for you :D
…rror instead cout/clog/cerr in shared memory object Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References