Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to C++17 on all platforms #2066

Closed
5 tasks done
elBoberido opened this issue Oct 26, 2023 · 0 comments · Fixed by #2096 or #2103
Closed
5 tasks done

Switch to C++17 on all platforms #2066

elBoberido opened this issue Oct 26, 2023 · 0 comments · Fixed by #2096 or #2103
Assignees
@elBoberido
Labels
enhancement New feature

Comments

@elBoberido
Copy link
Member

elBoberido commented Oct 26, 2023 •
edited
Loading

Brief feature description

C++23 was released earlier this year. We switched to C++14 around three years ago. Time to move to C++17.

Detailed information

C++17 has some nice features like:

  • structured bindings
    • e.g auto [bar, baz] = foo();
  • new attributes
    • fallthrough, maybe_unused and nodiscard
  • more constexpr
  • initializers in if and switch
  • class template argument deduction (CTAD)
  • check if includes are available with __has_include

Tasks

  • set the ICEORYX_CXX_STANDARD to 17 on all supported platforms
  • remove the #if __cplusplus >= 201703L switches
  • deprecate superfluous macros like IOX_NO_DISCARD
  • replace iox::byte with std::byte
  • simplify the platform and remove duplicated headers by using __has_include move to Simplify platform abstraction #2107
@elBoberido elBoberido added the enhancement New feature label Oct 26, 2023
@elBoberido elBoberido self-assigned this Nov 16, 2023
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Switch to C++17
2f7fc40
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Update release notes
a09a370
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Update documentation
c1aa03a
@elBoberido elBoberido mentioned this issue Nov 16, 2023
Merged
22 tasks
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Fix warning for useless cast
af804b4
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Make bazel build with C++17
f7ad923
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Fix GCC 8 build
622f9b5
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Fix Windows build
49729bc
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Make 'PortUser_IntegrationTest' more robust
079b6b8
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Fix Windows build
e900856
elBoberido added a commit that referenced this issue Nov 16, 2023
@elBoberido
iox-#2066 Make 'PortUser_IntegrationTest' more robust
5ed5231
elBoberido added a commit that referenced this issue Nov 17, 2023
@elBoberido
iox-#2066 Deactivate additional 'TomlGatewayConfigParser' test on Win…
16999d4 
…dows
elBoberido added a commit that referenced this issue Nov 17, 2023
@elBoberido
Merge pull request #2096 from eclipse-iceoryx/iox-2066-switch-to-C++17
8930633 
iox-#2066 Switch to C++17
@elBoberido elBoberido linked a pull request Nov 17, 2023 that will close this issue
iox-#2066 Switch to C++17 #2096
Merged
22 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove compliler switch from toml config fil…
1a314bc 
…e parser
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::invoke_result' instead of alias
957d196
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove iceoryx_platform/attributes.hpp
dc3930a
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_MAYBE_UNUSED' with '[[maybe_unu…
beba84f 
…sed]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_FALLTHROUGH' with '[[fallthroug…
d9dd200 
…h]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_NO_DISCARD' with '[[nodiscard]]'
3fb0a39
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Deprecate 'IOX_MAYBE_UNUSED', 'IOX_FALLTHROU…
04fd34f 
…GH' and 'IOX_NO_DISCARD'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update documentation
175aad1
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::byte' instead of 'iox::byte'
8e8cd3e
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 17, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update release notes
d2aa4be
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove compliler switch from toml config fil…
f149f46 
…e parser
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::invoke_result' instead of alias
44802a5
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove iceoryx_platform/attributes.hpp
b5dbe53
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_MAYBE_UNUSED' with '[[maybe_unu…
6226a22 
…sed]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_FALLTHROUGH' with '[[fallthroug…
3aafd95 
…h]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_NO_DISCARD' with '[[nodiscard]]'
d7b1bef
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Deprecate 'IOX_MAYBE_UNUSED', 'IOX_FALLTHROU…
9b21528 
…GH' and 'IOX_NO_DISCARD'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update documentation
7c0f2aa
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::byte' instead of 'iox::byte'
66318ff
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 18, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update release notes
8108449
@elBoberido elBoberido mentioned this issue Nov 18, 2023
Merged
22 tasks
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove compliler switch from toml config fil…
2da57d5 
…e parser
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::invoke_result' instead of alias
49486b6
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Remove iceoryx_platform/attributes.hpp
b7ad360
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_MAYBE_UNUSED' with '[[maybe_unu…
fa267d2 
…sed]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_FALLTHROUGH' with '[[fallthroug…
ae66b5a 
…h]]'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Replace 'IOX_NO_DISCARD' with '[[nodiscard]]'
03f4aa1
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Deprecate 'IOX_MAYBE_UNUSED', 'IOX_FALLTHROU…
ca59243 
…GH' and 'IOX_NO_DISCARD'
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update documentation
1ad2011
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Use 'std::byte' instead of 'iox::byte'
d75f30d
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Update release notes
992fef6
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Fix build failure on Arch Linux and aarch64
6aeb16c
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Fix pre-flight-check
ac7e300
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Nov 20, 2023
@elBoberido
iox-eclipse-iceoryx#2066 Fix pre-flight-check
b0e68f7
elBoberido added a commit that referenced this issue Nov 20, 2023
@elBoberido
Merge pull request #2103 from elBoberido/iox-2066-remove-compiler-swi…
1ac5726 
…tches-for-C++17

iox-#2066 Remove compiler switches for c++17
@github-project-automation github-project-automation bot moved this to Done in v3.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elBoberido elBoberido

Labels
enhancement New feature
Projects
v3.0
Status: Done
Milestone
No milestone
1 participant
@elBoberido