Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement uninitialized array #1614

Closed
elfenpiff opened this issue Sep 7, 2022 · 0 comments · Fixed by #1749 or #1774
Closed

implement uninitialized array #1614

elfenpiff opened this issue Sep 7, 2022 · 0 comments · Fixed by #1749 or #1774
Assignees
@FerdinandSpitzschnueffler
Labels
enhancement New feature globex good first issue Good for newcomers refactoring Refactor code without adding features
Milestone
High prio

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

In containers like the vector, list, optional, string etc. we have a byte array which stores the actual type. This byte array, can be extracted and used in those containers. This would reduce bugs since we may forget to define alignment or size properties correctly.
Furthermore we would get rid of the axivion/clang-tidy exceptions which would lead to more readable and cleaner code.

There is already the Buffer container in iceoryx_hoofs/internal/concurrent/lockfree_queue/buffer.hpp which partly implements what is required.

The container should be moved to cxx/uninitialized_array.hpp and refactored so that it fits the universal requirements to be used in the remaining containers.

Extracted from: #1196
@elfenpiff elfenpiff added enhancement New feature good first issue Good for newcomers refactoring Refactor code without adding features globex labels Sep 7, 2022
@elfenpiff elfenpiff added this to the Medium prio milestone Sep 7, 2022
@elfenpiff elfenpiff mentioned this issue Sep 7, 2022
Closed
85 tasks
Closed
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 13, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move lockfree_queue/buffer to containers/uni…
c3b6d62 
…nitialized_array

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 13, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Rename concurrent::Buffer to containers::Uni…
1344398 
…nitializedArray

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 13, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Rename concurrent::Buffer to containers::Uni…
cab7fa6 
…nitializedArray

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/cxx/
d3ff17c 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/conc…
26a7c93 
…urrent

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/posi…
3316bdf 
…x_wrapper/

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/posi…
404199e 
…x_wrapper/

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Remove unnecessary todos and clang-tidy supp…
33a3eb7 
…ressions

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2022
@elfenpiff
iox-eclipse-iceoryx#1614 Add policy to uninitialized array
066ce10 
Signed-off-by: Christian Eltzschig <me@elchris.org>
FerdinandSpitzschnueffler pushed a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@elfenpiff @FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Add policy to uninitialized array
56f7ff0 
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix typo, simplify array access
2d9fc89 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Remove template parameter and ptr methods, a…
d3df642 
…dd documentation

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Add tests and begin and end methods
06f728a 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix AUTOSAR warnings
0af5644 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move lockfree_queue/buffer to containers/uni…
257e587 
…nitialized_array

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Rename concurrent::Buffer to containers::Uni…
640121c 
…nitializedArray

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/cxx/
ec4ee78 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Oct 17, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use UninitializedArray in iceoryx_hoofs/conc…
7216066 
…urrent

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix typo, simplify array access
c28e14d 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Remove template parameter and ptr methods, a…
2dd9dd2 
…dd documentation

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Add tests and begin and end methods
677d23b 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix AUTOSAR warnings
1de8513 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Remove related todos
bb2d1e1 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix review findings
7a3b2fe 
Extend documentation, delete copy/move operations, forward to const
overloads, fix end() and tests

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Rename policy parameters
dd1a36f 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix named_pipe changes, update documentation
f14fddc 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move UninitializedArray to internal, add sta…
1f5f480 
…tic_assert

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Fix review findings
4c8ef81 
Use aligned_storage in optional, use char array in posix call, add tests

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use NonZeroedBuffer for groups in posix_acce…
be3a678 
…ss_rights.cpp

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
Merge pull request #1749 from ApexAI/iox-1614-implement-uninitialized…
3d96597 
…-array

iox-#1614 implement uninitialized array
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move uninitialized array to detail folder, n…
4c157ea 
…amespace iox

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Merged
21 tasks
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move uninitialized array to detail folder, n…
9d905aa 
…amespace iox

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 1, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move uninitialized array to detail folder, n…
edd3f99 
…amespace iox

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 2, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Move files
c6e8967 
Move header file to iox folder, remove 's' from buffer and container
modules

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 3, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Revert some changes, adapt clang tidy file
e988034 
Replace UninitializedArrays with ElementType char with char
array

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 4, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use struct for array alignment
042878c 
Refactoring in UninitializedArray, variant and optional. Change gcc
version to 8 for ubuntu build.

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 4, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use struct for array alignment
6cb1a0f 
Refactoring in UninitializedArray, variant and optional. Change gcc
version to 8 for ubuntu build.

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 4, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Use struct for array alignment
c31b000 
Refactoring in UninitializedArray, variant and optional. Change gcc
version to 8 for ubuntu build.

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Change byte* in call_at_index to void*, remo…
200616c 
…ve .data

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit to ApexAI/iceoryx that referenced this issue Nov 7, 2022
@FerdinandSpitzschnueffler
iox-eclipse-iceoryx#1614 Const correctness in variant_internal.hpp
bc37c9b 
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler added a commit that referenced this issue Nov 8, 2022
@FerdinandSpitzschnueffler
Merge pull request #1774 from ApexAI/iox-1614-move-uninitialized-array
6a58416 
iox-#1614 Move uninitialized array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler

Labels
enhancement New feature globex good first issue Good for newcomers refactoring Refactor code without adding features
Projects
None yet
Milestone
High prio
2 participants
@elfenpiff @FerdinandSpitzschnueffler