feat: add target filter query view#2892
feat: add target filter query view#2892MikaMauger wants to merge 1 commit intoeclipse-hawkbit:masterfrom
Conversation
|
Thanks @MikaMauger for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. |
|
|
@MikaMauger , |
|
Done! Also, the double brackets are from copied and pasted existing code. I can remove them, but I'll wait for the full review before doing so. |
| new SelectionGrid.EntityRepresentation<>(TargetFilterQueryGridItem.class, TargetFilterQueryGridItem::getId) { | ||
|
|
||
| @Override | ||
| protected void addColumns(final Grid<TargetFilterQueryGridItem> grid) { |
There was a problem hiding this comment.
I would like to see the actual query somehow - after all it is the most important thing of the target filter. Wether it would be as a tooltip or on click with a modal window IDK yet which one will be best. I guess if it is added as a column could be too long sometimes ...
| @@ -0,0 +1,292 @@ | |||
| package org.eclipse.hawkbit.ui.view; | |||
| @Route(value = "target_filter_queries", layout = MainLayout.class) | ||
| @RolesAllowed({ "TARGET_READ" }) | ||
| @Uses(Icon.class) | ||
| public class TargetFilterQueryView extends TableView<TargetFilterQueryView.TargetFilterQueryGridItem, Long> { |
There was a problem hiding this comment.
Overall looks good. However currently we created target filters in the target view - because we didn't have a target filter view. Now that it is introduced it makes sense for it to have a create option there maybe ... What do you think ?
4 participants
This MR introduces the
Target Filter Queriesview, aligned with the previous Hawkbit UI.Creation is not included yet, as target filter queries can already be created from the Targets view.
Currently, you can: