Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing release for windows #236

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tagged_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:

$url = $null
foreach ($asset in $RESPONSE_JSON.assets) {
if ($asset.browser_download_url -match ".zip") {
if ($asset.browser_download_url -match "-win.zip") {
$url = $asset.browser_download_url
break
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,10 @@ describe('Test generation and download of open api specification', () => {
)
.then(() => cy.get(GENERATION_uploadContentFileInput).attachFile('valid-yml.yml'))
.then(() => cy.get(GENERATION_uploadContent).should('not.exist'))
.then(() => cy.get(GENERATION_accordionTitle).should('exist').should('be.visible').should('contain.text', 'Properties')).wait(3000)
.then(() => cy.get(GENERATION_tbGenerateOpenApiButton).click({force:true})).wait(3000)
.then(() => cy.get(GENERATION_accordionTitle).should('exist').should('be.visible').should('contain.text', 'Properties'))
.wait(3000)
.then(() => cy.get(GENERATION_tbGenerateOpenApiButton).click({force: true}))
.wait(3000)
.then(() => cy.fixture('cypress/downloads/AspectDefault-open-api.yaml'));
});

Expand All @@ -143,7 +145,7 @@ describe('Test generation and download of open api specification', () => {
.then(() => cy.get(GENERATION_tbBaseUrlInput).focus().clear().type('https://example.com').blur())
.wait(7000)
.then(() => cy.get(GENERATION_tbBaseUrlInputError).should('not.exist'))
.then(() => cy.get(GENERATION_tbGenerateOpenApiButton).click({force:true}).wait(5000))
.then(() => cy.get(GENERATION_tbGenerateOpenApiButton).click({force: true}).wait(5000))
.then(() => cy.fixture('cypress/downloads/AspectDefault-open-api.yaml'));
});

Expand Down
6 changes: 3 additions & 3 deletions core/electron-libs/menu/edit-sub-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ function editSubmenu(translation) {
{
id: 'OPEN_SELECTED_ELEMENT',
label: translation.OPEN_SELECTED_ELEMENT,
enabled: false,
enabled: true,
icon: getIcon(icons.OPEN_SELECTED_ELEMENT.disabled),
click: (menuItem, browserWindow, _) => browserWindow.webContents.send(SIGNAL_OPEN_SELECTED_ELEMENT),
},
{
id: 'REMOVE_SELECTED_ELEMENT',
label: translation.REMOVE_SELECTED_ELEMENT,
enabled: false,
enabled: true,
icon: getIcon(icons.REMOVE_SELECTED_ELEMENT.disabled),
click: (menuItem, browserWindow, _) => browserWindow.webContents.send(SIGNAL_REMOVE_SELECTED_ELEMENT),
},
Expand All @@ -52,7 +52,7 @@ function editSubmenu(translation) {
{
id: 'CONNECT_ELEMENTS',
label: translation.CONNECT_SELECTED_ELEMENTS,
enabled: false,
enabled: true,
icon: getIcon(icons.CONNECT_ELEMENTS.disabled),
click: (menuItem, browserWindow, _) => browserWindow.webContents.send(SIGNAL_CONNECT_ELEMENTS),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ <h3>{{ 'GENERATE_OPENAPI_SPEC_DIALOG.GENERATING' | translate }}</h3>
</mat-dialog-content>

<mat-dialog-actions align="end">
<button mat-flat-button (click)="close()" data-cy="cancelOpenApiButton">{{ 'GENERATE_OPENAPI_SPEC_DIALOG.BUTTON.CANCEL' | translate }}</button>
<button mat-flat-button (click)="close()" data-cy="cancelOpenApiButton">
{{ 'GENERATE_OPENAPI_SPEC_DIALOG.BUTTON.CANCEL' | translate }}
</button>
<button
(click)="generateOpenApiSpec()"
type="button"
Expand Down
Loading