Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute full path as modelURI causes error #72 #80

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Absolute full path as modelURI causes error #72 #80

merged 1 commit into from
Feb 17, 2021

Conversation

vhemery
Copy link
Contributor

@vhemery vhemery commented Feb 17, 2021

Fixing absolute file URI with device for windows.
Moving the adaptModelUri method to ModelResourceManager.

Absolute full path as modelURI causes error #72
1f94a46 
Fixing absolute file URI with device for windows.
Moving the adaptModelUri method to ModelResourceManager.

Signed-off-by: vhemery <vincent.hemery@csgroup.eu>
@vhemery vhemery mentioned this pull request Feb 17, 2021
Closed
@ndoschek ndoschek self-requested a review February 17, 2021 15:49
ndoschek
ndoschek approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@ndoschek ndoschek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for ensuring full paths work correctly on Windows as well! I tested the change on Linux and can verify everything works as expected. Making the modelUri handling customizable is a great benefit, thanks again! 🎉

@ndoschek ndoschek merged commit 4d58241 into eclipse-emfcloud:master Feb 17, 2021
@vhemery vhemery deleted the Absolute_full_path_as_modelURI_causes_error__#72 branch September 13, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndoschek ndoschek ndoschek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhemery @ndoschek