You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned on Spectrum [1] the getAll of the client has an incorrect return type and should return a map-like structure that maps from file URI to object.
I suggest to introduce a wrapper object that resembles EMF's Resource class, like this:
{
modelUri : string,
eContent : object[]
}
Then getAll() simply returns an array of these objects and everybody can access each model's URI and content statically.
This abolishes any use of Object.entries or Object.keys on the result of getAll().
- Add missing method for listing model uris: getModelUris
-- Add to example API test menu
- Ensure getAll returns a list of model
-- Introduce dedicated model type with modelUri and content properties
- Clean up code and use more types
Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
As mentioned on Spectrum [1] the
getAll
of the client has an incorrect return type and should return a map-like structure that maps from file URI to object.[1] https://spectrum.chat/emfcloud/modelserver/modelserverclient-getall-has-compile-time-type-string-string-but-different-runtime-type-object~f85ffe9d-1639-4bb4-9f01-6b600d9bf626
The text was updated successfully, but these errors were encountered: