Skip to content

Conversation

@jansupol
Copy link
Contributor

@jansupol jansupol commented Dec 4, 2024

No description provided.

…bJsonProvider

Signed-off-by: jansupol <jan.supol@oracle.com>
Signed-off-by: jansupol <jan.supol@oracle.com>
Signed-off-by: jansupol <jan.supol@oracle.com>
}
}

private Optional<List<JaxRSFeatureState>> jaxRSFeature = Optional.empty();
Copy link
Member

@jbescos jbescos Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it makes sense to remove Optional and just have the list?:
private final List<JaxRSFeatureState> jaxRSFeatures = new ArrayList<>();

If empty, hasJaxrsFeature returns false

I found this is more understandable, although this is only a personal opinion.

@senivam senivam added this to the 2.46 milestone Dec 17, 2024
@senivam senivam merged commit c312e20 into eclipse-ee4j:2.x Dec 17, 2024
7 checks passed
@jansupol jansupol deleted the jaxrsfeature.configure branch February 3, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants